Conversation
summeroff
force-pushed
the
browser_source_message
branch
from
ed52aae to
f967fad
Compare
summeroff
force-pushed
the
browser_source_message
branch
from
f967fad to
94a60bc
Compare
This reverts commit 414238e.
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a prototype bidirectional messaging system for browser sources, allowing communication between the OBS application and browser content. The implementation adds functionality to send messages from the app to browsers and receive messages from browsers back to the app.
- Adds messaging infrastructure with
MessageToBrowsermethod andmessagesToAppvector storage - Implements message handling through OBS source interface callbacks and process message handlers
- Enables remote debugging capabilities for browser instances
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| obs-browser-source.hpp | Adds message storage vector and MessageToBrowser method declaration |
| obs-browser-source.cpp | Implements MessageToBrowser method to dispatch JS events |
| obs-browser-plugin.cpp | Adds source callbacks for message handling and retrieval |
| cmake/os-windows.cmake | Contains duplicate message statement |
| browser-client.cpp | Adds messageToApp handler and debug logging |
| browser-app.cpp | Adds debugging port configuration and messageToApp function exposure |
Comments suppressed due to low confidence (1)
obs-browser-source.cpp:157
- This line appears to be orphaned code from a previous implementation and should be removed as it references an undefined variable 'async'.
if (!async) {
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
sandboxcoder
approved these changes
Sep 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New API to send messages between browser source and app.